Ensure teardown is always executed#117
Open
chitoku-k wants to merge 1 commit into
Open
Conversation
molovo
force-pushed
the
fix-test-teardown
branch
from
July 14, 2026 23:29
2dcf265 to
dd69dba
Compare
molovo
removed their request for review
July 14, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases especially when tests failed due to
err_exit, the teardown function was not executed. This PR uses trap functions to ensure it is always executed.@setup { tempfile=test touch $tempfile } @teardown { # Here is not executed in some of the following cases rm $tempfile } @test 'case ok' { # This case is totally OK because `run` temporarily disables `err_exit` (using unsetopt) run false } @test 'case ng' { # This PR fixes this case where the test fails with `err_exit` being set false }I tried to show this by adding test cases that cover them which resulted in the entire test to break because it needs to be somehow failed...